Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Dec 19, 2025

On top of #213

The hypervisor cro has the hypervisor-id, so let's use that one
instead of looking it up via the name.

@fwiesel fwiesel requested a review from notandy December 19, 2025 11:16
@fwiesel fwiesel force-pushed the eviction-hypervisor-id branch from f6c743d to 2e210b9 Compare December 19, 2025 11:46
@fwiesel fwiesel force-pushed the eviction-hypervisor-id branch from 2e210b9 to fc5ed5c Compare December 19, 2025 15:18
The hypervisor cro has the hypervisor-id, so let's use that one
instead of looking it up via the name.
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 49.62% (+0.33%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller.go 37.73% (+0.93%) 220 (-11) 83 (-2) 137 (-9) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller_test.go

@fwiesel fwiesel merged commit 768f631 into main Dec 19, 2025
6 checks passed
@fwiesel fwiesel deleted the eviction-hypervisor-id branch December 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants