Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Dec 18, 2025

When there is no maintenance-contoller profile the GardenerLifecycleController will now set the hypervisor cro maintenance field. For confirmation, it will look on the conditions.
That renders the labels obsolete.

@fwiesel
Copy link
Contributor Author

fwiesel commented Dec 19, 2025

Based on #213

@fwiesel fwiesel force-pushed the no-more-labels branch 2 times, most recently from 1f95637 to 0ebd9b3 Compare December 19, 2025 15:24
When there is no maintenance-contoller profile the GardenerLifecycleController
will now set the hypervisor cro maintenance field.
For confirmation, it will look on the conditions.
That renders the labels obsolete.
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 54.32% (+4.70%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd/main.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller.go 72.58% (+59.02%) 62 (+3) 45 (+37) 17 (-34) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/node_eviction_label_controller.go 0.00% (-40.54%) 0 (-74) 0 (-30) 0 (-44) 💀 💀 💀 💀
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/utils.go 82.61% (+10.06%) 46 (-5) 38 (+1) 8 (-6) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/node_eviction_label_controller_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants