durability: Notify waiters after lockfile is dropped #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
reviewed
Jan 15, 2026
Notifications were sent shortly before dropping the actor (and thus, the lockfile), which could cause the `close` future to return while the lock is still held. This can lead to a race if the database is re-opened immediately, such as in `TestDB::reopen()`, causing test flakes.
kim
force-pushed
the
kim/durability/notify-after-drop
branch
from
43a473a to
592b792
Compare
bfops
approved these changes
Jan 15, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
this fix makes sense to me! Thank you for finding it 🙏 that seems like a pain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications were sent shortly before dropping the actor (and thus, the lockfile), which could cause the
closefuture to return while the lock is still held.This can lead to a race if the database is re-opened immediately, such as in
TestDB::reopen(), causing test flakes.Expected complexity level and risk
1
Testing
Should result in "Database is already opened" test flakes to go away.