CI - Fix hint for fixing llm benchmarks #4040
Open
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| > Model IDs passed to `--models` must match configured routes (see `model_routes.rs`), e.g. `"openai:gpt-5"`. | ||
|
|
Contributor
There was a problem hiding this comment.
I would keep this because it is true and consistent with this DEVELOP.md. You can do this, you just need the API keys.
We should perhaps just add a note here that CI will run this for you if you comment /update-llm-benchmark.
There was a problem hiding this comment.
It seems to me like outsiders can't run /update-llm-benchmark or it takes 5+ minutes and does not say anyting until it is done.
Collaborator
Author
There was a problem hiding this comment.
Okay, updated!
@Boegie19 that's correct, for security reasons. I've tried to add a comment about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I believe that local users do not have API tokens for OpenAI, so the existing hint was not helpful. Apparently the correct path is to post
/update-llm-benchmarkon the PR and let the CI take care of it.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
None