Add a typed query builder for the typescript client #4021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different packages/examples
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
Do we have tests for the typescript sdk that we could potentially extend to exercise the query builder?
| on: ( | ||
| left: IndexedRowExpr<TableDef>, | ||
| right: IndexedRowExpr<RightTable> | ||
| ) => EqExpr<TableDef | RightTable> |
Collaborator
There was a problem hiding this comment.
This is still too permissive, right? Is it possible to restrict it?
Contributor
Author
There was a problem hiding this comment.
What are you concerned about this allowing? The return type of EqExpr doesn't enforce that columns are indexed, but the left and right parameters only have indexed columns, so anyone constructing queries the normal way won't run into issues.
Contributor
Author
|
I added another version of the query builder tests that uses the test-app bindings in client_query.test.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This moves the query builder code out of the
serverpackage and intolibso it can be shared by the client and server.I put the query builder in the
index.tsof module bindings as aqueryobject that can be imported. The typescripttest-apphas an example of using it with the subscription builder.This is branched off of
https://github.com/clockworklabs/SpacetimeDB/pull/3980.API and ABI breaking changes
This extends the client subscription builder API to allow
string | RowTypedQuery<any, any>, so existing client code should be fine.Expected complexity level and risk
1.5. This is low risk.
Testing
I manually tested that the test app still works locally.