-
Notifications
You must be signed in to change notification settings - Fork 669
Add smoketests for template generation #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drogus
wants to merge
28
commits into
master
Choose a base branch
from
drogus/templates-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97e90ea to
2ab9c36
Compare
We now specify the path in the template, similarly to what we do in quickstart-chat-rust, so no version change is needed.
e1bcaad to
4b4f94b
Compare
…gus/templates-tests
This reverts commit ccf0ef2.
23b4b2c to
bbb0638
Compare
2e87244 to
cba8bfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no runtime change
This change does not affect the final binaries
release-any
To be landed in any release window
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Basic tests for templates, the test tries to generate each of the template, build and publish the SpacetimeDB part, and build or type check the client side.
This PR also includes bindings for all of the clients as it's needed for the tests to work and given the choices to either generate during the test run or include the bindings in git we chose the latter. This makes it consistent across the templates as some of them already included bindings.
Expected complexity level and risk
1