Skip to content

align UUID reducer examples with allowed signatures #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GEFNENEN wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

align UUID reducer examples with allowed signatures #3999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
000febd
align UUID reducer examples with allowed signatures
GEFNENEN Jan 12, 2026
1291883
Merge pull request #1 from GEFNENEN/GEFNENEN-patch-doc-fix
GEFNENEN Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/bindings/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ impl ReducerContext {
/// use spacetimedb::{reducer, ReducerContext, Uuid};
///
/// #[reducer]
/// fn generate_uuid_v4(ctx: &ReducerContext) -> Uuid {
/// fn generate_uuid_v4(ctx: &ReducerContext) {
/// let uuid = ctx.new_uuid_v4();
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function new_uuid_v4() returns anyhow::Result<Uuid>, but the Result is not being handled here. Since the reducer signature returns (), you need to either:

  1. Handle the error explicitly (e.g., using .unwrap(), .expect(), or a match statement), or
  2. Change the reducer signature to return Result<(), impl std::fmt::Display> and use the ? operator to propagate the error, similar to the generate_uuid_v7 example below.
Suggested change
/// let uuid = ctx.new_uuid_v4();
/// let uuid = ctx.new_uuid_v4().expect("failed to generate UUID v4");

Copilot uses AI. Check for mistakes.
/// log::info!(uuid);
/// }
Expand All @@ -1070,9 +1070,10 @@ impl ReducerContext {
/// use spacetimedb::{reducer, ReducerContext, Uuid};
///
/// #[reducer]
/// fn generate_uuid_v7(ctx: &ReducerContext) -> Result<Uuid, Box<dyn std::error::Error>> {
/// fn generate_uuid_v7(ctx: &ReducerContext) -> Result<(), Box<dyn std::error::Error>> {
/// let uuid = ctx.new_uuid_v7()?;
/// log::info!(uuid);
/// Ok(())
/// }
/// # }
/// ```
Expand Down
Loading