Implement dimensional Strang splitting in 2D.#651
Open
ketch wants to merge 1 commit intoclawpack:masterfrom
Open
Implement dimensional Strang splitting in 2D.#651ketch wants to merge 1 commit intoclawpack:masterfrom
ketch wants to merge 1 commit intoclawpack:masterfrom
Conversation
Member
|
Huh, was their a reason we did not do this in the past beyond it being inefficient? |
Member
Author
|
Just that. An alternative would be to implement it efficiently, but only for fixed timesteps. But given that nobody has asked for it until now, I don't think it's worth it. Don't merge this -- we'll be adding a test first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.