Add test for dam_break problem that uses Python Roe solver.#534
Open
ketch wants to merge 1 commit intoclawpack:masterfrom
Open
Add test for dam_break problem that uses Python Roe solver.#534ketch wants to merge 1 commit intoclawpack:masterfrom
ketch wants to merge 1 commit intoclawpack:masterfrom
Conversation
Member
Author
|
Note that this will fail on travis until clawpack/riemann#109 is merged. |
Member
Author
|
@mandli If you can take a quick look at this, I'd like to merge both it and clawpack/riemann#109. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests clawpack/riemann#109. It would be nice to also add a test against the exact solver that is in that PR. I will do it if I have time.