Polynomial reconstruction in SharpClaw

[sanromd]

This PR adds a routine for polynomial based reconstruction in SharpClaw. In detail,

• 4th and 6th order Polynomial reconstrcution
• 8th and 10th order reconstruction are also included but have not been fully tested yet
• renames "weno_order" to "reconstruction_order"
• deallocate calls for WENO5 and Poly_comp
• sets number of ghost cells for either Weno or Poly in solver
• documentation

[ketch]

Just a reminder for anybody testing this -- you'll need to rebuild:

cd clawpack
pip install -e .

[ketch]

Just a note: renaming weno_order to reconstruction_order is backward-incompatible, but it is a small enough change that I think it's okay for this to go into 5.3.

[sanromd]

@ketch, if needed for 5.4 I can add backward-compatibility...

[ketch]

Maybe that's a good idea; we can just emit a warning saying that the old attribute will be deprecated in future versions.

[ketch]

I just merged in the fix for the doctests (from master) so this is passing now.

[ketch]

This should say

From 5th to 17th order (odd) for WENO reconstruction and from 4th to 10th order (even) for piecewise polynomial reconstruction.

[ketch]

Ah, I just noticed that it's wrong in master...

[ketch]

This looks great and will be very useful. It would of course be nice to have:

• A test that uses the new reconstruction
• At least some comments at the top of poly.f90 documenting the functions there.

[coveralls]

Coverage remained the same when pulling 5f6ee25 on sanromd:dev-poly into e20a787 on clawpack:master.

[sanromd]

@ketch working on

• acoustics_1d test
• comments on poly
• documentation on solver

[mandli]

What's the status of this PR?

[sanromd]

I made some modifications to it in my fork and rebased it... I haven't got
time to finalize testing. I will update it soon.

On Saturday, October 24, 2015, Kyle Mandli notifications@github.com wrote:

What's the status of this PR?

—
Reply to this email directly or view it on GitHub
#492 (comment).

Damián

ubi dubium ibi libertas

[mandli]

Thanks for the update. Would you like this included in the 5.3.1 release or would this be better for the 5.4.0 release?

[ketch]

If @sanromd can add a test or two soon, it would be great to get this into 5.4.0. It probably shouldn't go into 5.3.1 since it's a major feature and 5.4 is coming very soon anyway.

[coveralls]

Changes Unknown when pulling 458933d on sanromd:dev-poly into * on clawpack:master*.

[coveralls]

Coverage decreased (-0.01%) to 69.671% when pulling c0095d2 on sanromd:dev-poly into 314fd93 on clawpack:master.