Improve the main README.md and add CODE_OF_CONDUCT.md#97
Merged
rjleveque merged 3 commits intoclawpack:masterfrom Aug 16, 2025
Merged
Improve the main README.md and add CODE_OF_CONDUCT.md#97rjleveque merged 3 commits intoclawpack:masterfrom
rjleveque merged 3 commits intoclawpack:masterfrom
Conversation
mandli
reviewed
Jul 21, 2025
Member
mandli
left a comment
mandli
left a comment
There was a problem hiding this comment.
Looks good to me.
I think I added similar additions to the other repos' README.
Quick clarification, this is not the NumFOCUS CoC. Is this just to add a place holder so that we can drop in the replacement?
Member
Author
|
Oops, I copied over the wrong CoC file. Now it's fixed. |
mandli
approved these changes
Jul 22, 2025
Member
mandli
left a comment
mandli
left a comment
There was a problem hiding this comment.
Looks good. Makes me wonder if there's an easy way to just point to a file in another repository and have it recognized, but probably not easily for the obvious reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/rjleveque/classic/tree/README_CoC
for a preview of how this looks on the github landing page. Note that the "Code of Conduct" link just before the rendered README on that page is generated automatically once
CODE_OF_CONDUCT.mdis added, as is the "License" link.If this looks ok, I will also add the CoC to other repos, and improve their
README.mdfiles too, to point to the documentation and main clawpack/clawpack repo.