Fix pg_cron fast shutdown hang with sync replication #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast shutdown may hang indefinitely when
synchronous_standby_namesrequirement cannot be satisfied due to an insufficient number of synchronous replicas. In this situation, pg_cron can block waiting for a synchronous replication acknowledgment.Example:
gdb:
This happens because pg_cron installs a custom
SIGTERMhandler that does not setProcDiePending, causingSyncRepWaitForLSN()to never exit its wait loop.Fix this by switching to the standard
SIGTERMhandler (die()). Additionally, remove the customSIGHUPhandler and rely onSignalHandlerForConfigReload()instead.