Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the workspace to NX 21, removes legacy test configurations, and standardizes Vite/project settings across services, libraries, and playgrounds.
- Upgrade Nx and related plugins to version 21 and update package.json dependencies
- Remove standalone
tsconfig.spec.json,jest.config.ts, and legacy targets in service and libraryproject.json - Migrate all Vite configs to the inferred NX pattern and standardize quotes,
outDir/outputs, and plugin settings
Reviewed Changes
Copilot reviewed 239 out of 243 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Added new path aliases for Wuppertal collab modules |
| services/rasterfari-tileserver-wms-companion/tsconfig.spec.json | Deleted spec config; tests no longer referenced |
| package.json | Bumped version and upgraded NX, Storybook, Vitest |
| nx.json | Removed legacy Jest targets; added NX plugin configs |
| playgrounds/vector/vite.config.ts | Converted to inferred pattern; unused options var |
Comments suppressed due to low confidence (1)
Comment on lines
+7
to
16
| const configValues = { default: {}, development: {}, production: {} }; | ||
|
|
||
| // Determine the correct configValue to use based on the configuration | ||
| const nxConfiguration = process.env.NX_TASK_TARGET_CONFIGURATION ?? "default"; | ||
|
|
||
| const options = { | ||
| ...configValues.default, | ||
| ...(configValues[nxConfiguration] ?? {}), | ||
| }; | ||
|
|
There was a problem hiding this comment.
The configValues and options variables are defined but never used in defineConfig. Consider removing them or merging options into the config object to avoid dead code.
Suggested change
| const configValues = { default: {}, development: {}, production: {} }; | |
| // Determine the correct configValue to use based on the configuration | |
| const nxConfiguration = process.env.NX_TASK_TARGET_CONFIGURATION ?? "default"; | |
| const options = { | |
| ...configValues.default, | |
| ...(configValues[nxConfiguration] ?? {}), | |
| }; | |
| // Removed unused configValues and options variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
squashed version of dx/nx-migrate-21
#327
for easier rebase.
consider splitting out migration to infered projects into new PR or postpone that part.
for that plugins in nx.json and changes to project.json and tooling files would need to be reverted.