Browserify support for client (one-line patch)#53
Open
jonasfj wants to merge 1 commit intochjj:masterfrom
Open
Browserify support for client (one-line patch)#53jonasfj wants to merge 1 commit intochjj:masterfrom
jonasfj wants to merge 1 commit intochjj:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Term.js is awesome... and well packaged. In fact it can already be used in browserify, if required as follows:
By specifying
browser: './src/term.js', browserify will load./src/term.jsas it's main file instead of./index.js.I seriously doubt anybody wants to use the connect middleware in their browser environment :)
I checked and everything else seems to work as intended.