(fix) ObjC: unified cell height logic with swift#209
Open
DanijelBojcic wants to merge 1 commit intochiahsien:developfrom
Open
(fix) ObjC: unified cell height logic with swift#209DanijelBojcic wants to merge 1 commit intochiahsien:developfrom
DanijelBojcic wants to merge 1 commit intochiahsien:developfrom
Conversation
kk00karl
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that the SWIFT and ObjC packages differ in cell height logic.
The SWIFT version will set the height of the cell no matter what and will set the width when it's bigger than 0, otherwise it will set it to 50% of the screen width.
On ObjC on the other hand it will only set the height if the width is also bigger than 0.
The logic in Swift is here and the logic in ObjC is here