[EnvironmentCookbookVersionsEndpoint] Use cookbook_obj_cache in depsolve before calling get_data #363
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve before calling get_data Check the cookbook_obj_cache before calling get_data in depsolve to avoid redundant fetches during backtracking. Also preserve the cache across failed recursive branches by not destructuring [nil, nil] returns into cookbook_obj_cache. Signed-off-by: David Crosby <dcrosby@fb.com>
|
jaymzh
approved these changes
Feb 11, 2026
tpowell-progress
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the cookbook_obj_cache before calling get_data in depsolve to avoid redundant fetches during backtracking. Also preserve the cache across failed recursive branches by not destructuring [nil, nil] returns into cookbook_obj_cache.
This ~halves the time my client takes to do depsolving when using Chef Zero
Description
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.