feat(policy): implement policy eval #2611
Open
+1,478
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Piskoo
changed the title
Piskoo
changed the title
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
migmartri
requested changes
Dec 15, 2025
| option go_package = "github.com/chainloop-dev/chainloop/app/controlplane/api/controlplane/v1;v1"; | ||
|
|
||
| service PolicyEvaluationService { | ||
| rpc Evaluate(PolicyEvaluationServiceEvaluateRequest) returns (PolicyEvaluationServiceEvaluateResponse); |
Member
There was a problem hiding this comment.
is it possible that this PR contains too much information, including remote evaluations or smth like that?
| # default: true | ||
| # url: http://localhost:8002/v1 | ||
| # Policy providers configuration | ||
| policy_providers: |
| } | ||
|
|
||
| // Call business layer to evaluate the policy | ||
| result, err := s.uc.Evaluate(ctx, &biz.PolicyEvaluationEvaluateOpts{ |
Member
There was a problem hiding this comment.
why isn't the evaluation happening client side? Why did we move it server-side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new
chainloop policy evalcommand that evaluates policies using the control plane with organization settings, supporting both generic and material-based policy evaluation.Differences
--allowed-hostnames