-
Notifications
You must be signed in to change notification settings - Fork 380
venafi: Issuer custom fields documentation #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-next
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -304,3 +304,36 @@ metadata: | |||||||
| ] | ||||||||
| ... | ||||||||
| ``` | ||||||||
| Starting `v1.20`, you can use `venafi.cert-manager.io/custom-fields` annotation on `Issuer` or `ClusterIssuer` objects. | ||||||||
| This configuration would be applied to all Certificate requests created from `Issuer`. | ||||||||
|
|
||||||||
| It is possible to override or append custom configuration to a specific `Certificate`, in example. | ||||||||
| given following `Issuer` | ||||||||
| ```yaml | ||||||||
| apiVersion: cert-manager.io/v1 | ||||||||
| kind: Issuer | ||||||||
| metadata: | ||||||||
| name: corp-issuer | ||||||||
| annotations: | ||||||||
| [ | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| {"name": "Environemnt", "value": "Dev"}, | ||||||||
| ] | ||||||||
| ``` | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| and `Certificate` | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| ```yaml | ||||||||
| apiVersion: cert-manager.io/v1 | ||||||||
| kind: Certificate | ||||||||
| metadata: | ||||||||
| name: example-com-certificate | ||||||||
| annotations: | ||||||||
| venafi.cert-manager.io/custom-fields: |- | ||||||||
| [ | ||||||||
| {"name": "Team", "value": "amber"}, | ||||||||
| ] | ||||||||
| ... | ||||||||
| ``` | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| Final configuration will be: | ||||||||
| ```json | ||||||||
| {"name": "Environemnt", "value": "Dev"}, | ||||||||
| {"name": "Team", "value": "amber"} | ||||||||
| ``` | ||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that you put this into it's own heading so it's clear it is additional new functionality but also optional: