Add an abstract base to generated parameters structures.#37
Open
Add an abstract base to generated parameters structures.#37
Conversation
This was referenced Jan 10, 2018
Merged
aea32e3 to
9956bf1
Compare
Collaborator
Author
|
Force pushed after a cleaning of this branch history. |
Collaborator
Author
|
Since all tests are declared in the same rostest, they all share the same environment, thus the same param server. |
9956bf1 to
1561f33
Compare
Collaborator
Author
|
Rebased on |
Collaborator
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parametersobjects.fromParamServerComes in replacement to #35 .
Details
Please consider the following example :
This PR does not change the default behavior while allowing one to use a unique
rosparam_handler::ParameterPtrin a base class and instantiate it to a different parameter type. All functions remain available through the base pointer.The main drawback here is that to access the actual members of the instantiated object one has to cast the pointer to the appropriate type (either statically or dynamically).
See helper functions :
All former tests are passing and a I added one for this new scheme.
Their is also a test-case demonstrating how to test
dynamic_reconfigurecallback withrosparam_handler.This PR also turns
*Parametersinto copyable objects :Please consider this PR as Work In Progress until I add some more tutorial to rosparam_handler_tutorial.