-
-
Notifications
You must be signed in to change notification settings - Fork 227
ci: implement benchmarks and automated CI workflow #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Pull Request Test Coverage Report for Build 20820648323Details
💛 - Coveralls |
- Add benchmark.ts with tests for RBAC, ABAC, and Basic models - Add benchmark script to package.json - Install benchmark.js and @types/benchmark dependencies - Create GitHub Actions workflow for automated benchmarking on PRs - Update .gitignore to exclude benchmark artifacts Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
- Add comprehensive README for benchmark directory - Fix ESLint errors in benchmark.ts - Verify all tests still pass Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
- Extract JSON parsing logic to separate extract-results.js script - Extract comparison logic to separate compare-results.js script - Improve error handling in benchmark workflow - Add benchmark JS files to .eslintignore - Fix misleading comment in benchmark.ts Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
- Fix usage message in extract-results.js and compare-results.js - Add file existence checks in benchmark.ts to validate example files - Improve error handling in workflow using continue-on-error - Make benchmark failures more visible while still allowing comparison Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
|
@copilot fix: |
The workflow was failing because after checking out the base branch, the benchmark scripts (extract-results.js and compare-results.js) no longer exist. Now we copy them to /tmp before checkout and use them from there for processing base branch results. Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
... Fixed in commit 2ec74ba. The issue was that the workflow checked out the base branch to run benchmarks on it, but the benchmark scripts (extract-results.js and compare-results.js) only exist in the PR branch. Now the scripts are copied to /tmp before checking out the base branch, so they're available for processing results from both branches. |
📊 Benchmark ResultsPerformance comparison between base branch and PR:
Legend:
|
Benchmark Implementation Plan
Summary
✅ Implementation Complete!
This PR adds a comprehensive benchmark suite and automated CI workflow to node-casbin:
What's Included
Benefits
Recent Fix
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.