feat: implement self* methods using WithoutNotify pattern (sync with Go) #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20877464519Details
💛 - Coveralls |
Huggin423
force-pushed
the
fix/506-go-style-implementation
branch
from
c64e7a6 to
289e9fb
Compare
Huggin423
force-pushed
the
fix/506-go-style-implementation
branch
from
289e9fb to
afa3426
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the self* methods in the Management API to use a new *WithoutNotify pattern, aligning with the Go Casbin implementation. The refactoring prevents infinite loops in distributed environments by ensuring that self-operations bypass both adapter persistence and watcher notifications, operating strictly on the in-memory model.
Changes:
- Introduced new
*WithoutNotifyprotected methods inInternalEnforcerthat update only the in-memory model - Refactored all
self*methods inManagementEnforcerto delegate to the corresponding*WithoutNotifymethods - Added comprehensive test coverage to verify self-operations bypass adapters while correctly updating memory
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/managementAPI_self.test.ts | New comprehensive test suite validating that self* methods bypass adapters and update memory correctly, including edge cases |
| src/managementEnforcer.ts | Refactored all self* methods to call *WithoutNotify variants; added selfUpdatePolicies method; updated selfRemoveFilteredPolicy signature to use rest parameters |
| src/internalEnforcer.ts | Added six new *WithoutNotify protected methods that update the model without calling adapters or watchers; added comments clarifying when persistence occurs in existing methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add *WithoutNotify internal methods that skip adapter and watcher - Implement selfAddPolicy, selfRemovePolicy, selfUpdatePolicy, selfAddPolicies, selfRemovePolicies, selfRemoveFilteredPolicy, selfUpdatePolicies - These methods only update in-memory model to prevent infinite loops in distributed watcher scenarios - Add comprehensive unit tests with edge cases and grouping policy coverage - Align with Go Casbin implementation pattern Fixes casbin#506
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsluoyz
changed the title
This was referenced Jan 10, 2026
|
🎉 This PR is included in version 5.48.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the implementation to match the Go Casbin approach, as requested by the maintainer.
It introduces
*WithoutNotifyinternal methods that operate strictly on the memory model (bypassing both adapter and watcher) and updatesself*methods to call them directly. This prevents infinite loops in distributed environments.Related Issue
Fixes #506
Verification
selfAddPolicyupdates memory correctly without invokingadapter.addPolicy.