-
-
Notifications
You must be signed in to change notification settings - Fork 227
feat: prevent wildcard deletion in deleteUser/deleteRole APIs #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix enforcer.deleteUser() to prevent data loss
Prevent wildcard deletion in deleteUser/deleteRole methods
Dec 8, 2025
Member
|
@copilot don't modify yarn.lock |
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Contributor
Author
Pull Request Test Coverage Report for Build 20874840964Details
💛 - Coveralls |
hsluoyz
added a commit
that referenced
this pull request
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deleteUser() deleting all policies when called with empty string
Root Cause
The
enforcer.deleteUser()method does not validate theuserparameter. When called with an empty string'', it causes all policies to be deleted because empty string values are treated as wildcards inremoveFilteredPolicy. This results in SQL queries like:Changes Made
deleteUser()to reject empty/falsy user valuesdeleteRole()which has the same issuedeletePermission()and other similar methodsdeleteRoleForUser()- validates both user and roledeleteRolesForUser()- validates userdeletePermissionsForUser()- validates userdeletePermissionForUser()- validates userdeletePermission()- validates permission array is not emptySecurity Summary
No security vulnerabilities were found in the changes. The fix actually improves security by preventing accidental data loss when invalid parameters are provided.
Original prompt
casbin_ruletable #462💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.