fix(treatment-service): Add pubsub message ordering flag #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthari
approved these changes
Apr 17, 2025
bthari
left a comment
bthari
left a comment
There was a problem hiding this comment.
woah, I just saw this MR again, but LGTM! Thanks for catching this!
Collaborator
Author
|
Whoa thanks for the approval! I almost forgot about this! 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Message ordering is not turned on for PubSub subscriptions created by the Treatment Service (and by extension the XP plugin), which means that messages received are not guaranteed to be in order. This poses a problem when there is a high volume of messages sent by the Management Service in a short span of time, as the order of messages received is important since these messages directly impact how the correct treatment is assigned to each request (e.g. an experiment is repeatedly turned on and off over a short period of time).
This PR thus turns on message ordering all subscriptions created to ensure that all instances of the Treatment Service/plugin are consistent in serving the same treatment to each request by maintaining strict message ordering.
See for more details: https://cloud.google.com/pubsub/docs/ordering#go
Which issue(s) this PR fixes:
Fixes #