-
Notifications
You must be signed in to change notification settings - Fork 140
Review feedback #2333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review feedback #2333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No "(Inbound)" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to add (Inbound) in this dedicated diagram to show once. I'd rather hesitate to use it in all titles (text or diagram) because it's common sense that "Inbound Authentication" = "Authentication".
guides/security/authentication.md
Outdated
| [Learn more about advanced authentication options in Node.js](../../node.js/authentication#strategies){.learn-more} | ||
| <div class="impl java"> | ||
|
|
||
| [Learn more about advanced authentication options](../../java/security#spring-boot){.learn-more} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All learn-more links are complete sentences that should have an ending, usually a dot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| The building blocks are: | ||
|
|
||
| - [Authentication](./authentication ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [Authentication](./authentication ) | |
| - [(Inbound) Authentication](./authentication ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see before
Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com>
|
Those two points are missing if I'm not mistaken:
|
done |
No description provided.