Provided a better solution for reading dead outbox entries #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraunMatthias
requested changes
Jul 18, 2025
java/outbox.md
Outdated
| Predicate where = null; | ||
| for(OutboxService service : outboxServices) { | ||
| OutboxServiceConfig config = outboxConfigs.getService(service.getName()); | ||
| Predicate targetPredicate = CQL.get(Messages.TARGET).eq(service.getName()).and(CQL.get(Messages.ATTEMPTS).ge(config.getMaxAttempts())); |
Contributor
There was a problem hiding this comment.
why do we need to filter by individual outbox and then OR the condition meeting all outboxes?
Contributor
Author
There was a problem hiding this comment.
@BraunMatthias Every outbox can have its own configuration for maxAttempts. To read only the dead entries per outbox, this filter is required.
Contributor
There was a problem hiding this comment.
same reason - I just overlooked this aspect
Co-authored-by: BraunMatthias <59841349+BraunMatthias@users.noreply.github.com>
Co-authored-by: BraunMatthias <59841349+BraunMatthias@users.noreply.github.com>
BraunMatthias
approved these changes
Jan 22, 2026
Contributor
Author
|
@smahati Can you please review this PR? |
smahati
approved these changes
Jan 22, 2026
Contributor
Author
|
@smahati Thank you! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.