fix automatic to explicit index parameter conversion#12
Merged
cachapa merged 2 commits intocachapa:masterfrom May 3, 2025
Merged
fix automatic to explicit index parameter conversion#12cachapa merged 2 commits intocachapa:masterfrom
cachapa merged 2 commits intocachapa:masterfrom
Conversation
Owner
|
Thanks, Janez! |
Contributor
Author
|
Hey Daniel, that is a bit awkward, but running I tried to run the workflow locally but got stuck in networking stuff (it expects ipv6, which doesn't work in my network because of reasons) so at this point I would be extremely grateful if you could have a look at this. |
Owner
|
I think I see the problem - the GitHub runner seems to be running a more recent version of Dart than the one shipped with Flutter. I'm having the same issue in other projects. Let's just ignore it for now. Thanks again for your effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the hood sql_crdt operates with explicit parameter indices (?1, ?2. ?3,... ) which leads to conflicts whenever a client uses implicit parameter indexing (?, ?, ?,... ).
This PR ensures parameter conversion from implicit to explicit.