Open
Conversation
Fra-nk
reviewed
Aug 11, 2021
bvrnapi/lib/converters/http.py
Outdated
Comment on lines
14
to
18
| if not url or "@" in url: # empty url or url with @ symbol will always return None | ||
| return None | ||
| if "@" in url: # url with @ symbol will also return None | ||
| # TODO insert problem (why @ symbol in url? url with authentication or e-mail address?) | ||
| return None |
Contributor
There was a problem hiding this comment.
https://docs.python.org/3/library/urllib.parse.html wäre eine Idee hier.
Das Problem ist nur, dass manche gar kein "Scheme" enthalten.
Fra-nk
reviewed
Aug 11, 2021
| ENV MODULE_NAME="bvrnapi.main" | ||
|
|
||
| # Install Poetry | ||
| RUN curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | POETRY_HOME=/opt/poetry python && \ |
Contributor
There was a problem hiding this comment.
Nitpick, aber ich nutze bei so etwas gerne die Langform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.