Allow import and export statement#32
Open
fabiosantoscode wants to merge 1 commit intobrowserify:masterfrom
Open
Allow import and export statement#32fabiosantoscode wants to merge 1 commit intobrowserify:masterfrom
fabiosantoscode wants to merge 1 commit intobrowserify:masterfrom
Conversation
Author
|
Googlers from the future: I worked around this issue by setting the acorn options myself. Since this module doesn't use acorn directly to parse, you need to get the same acorn as the one falafel is using. Which is a bit weird with npm3. It's quite quirky and confusing, but that will do for this prototype. Cheers! |
|
@fabiosantoscode Hi, i check the falafel but got nothing for acorn, i use webpack 3.0, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, static-module crashes when reading modules which use the 'import' statement. This makes it fail to parse those modules and crash with the cryptic error message:
Which after some research I found comes from acorn, which is the crashing entity here :)
(my use case, IE how this crash affects me): This failure cascades to brfs, and from then on webpack's transform-loader. Webpack 2 now supports ES6 modules, which create-react-app favours. This made webpack fail to compile my project as it uses import statements.