Open
Conversation
The Error class wasn't namespaced properly everywhere. The few classes in this MR were referencing a non-existing class (`Braintree\Error`). This MR aims to fix the namespace so static analysis tools do not fail while looking for the non-existing class.
| # Changelog | ||
|
|
||
| ## 6.7.1 | ||
| * Fix wrong namespacing for the `Braintree\Result\ERror` class on docblocks |
There was a problem hiding this comment.
Suggested change
| * Fix wrong namespacing for the `Braintree\Result\ERror` class on docblocks | |
| * Fix wrong namespacing for the `Braintree\Result\Error` class on docblocks |
|
Hi @braintreeps Can you give this PR a review whenever possible? Thank you :) |
ElonSmithee
reviewed
May 18, 2022
| * @see PaymentMethodNonceGateway::create() | ||
| * | ||
| * @return PaymentMethodNonce|Error | ||
| * @return PaymentMethodNonce|Result\Error |
There was a problem hiding this comment.
Please make interface for those multiple different classes that are returned.
Contributor
|
Hey folks, we'll take a look and provide feedback. For braintree folks, ticket 2046 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Error class wasn't namespaced properly everywhere. The few
classes in this MR were referencing a non-existing class
(
Braintree\Error).This MR aims to fix the namespace so static analysis tools do not
fail while looking for the non-existing class.
Issue #314
Checklist