ostree-ext: Make new packing if using prior build fails #1880
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of the chunking process by handling failures when reusing a prior build's packing structure. Instead of panicking, it now gracefully falls back to creating a new packing structure. The changes include replacing panic! with bail! for recoverable errors and wrapping the call to basic_packing_with_prior_build in a match to handle the error case. This is a solid improvement. I've added one suggestion to further improve robustness by replacing an assert! with a check that returns a Result, which is in line with the goals of this PR.
|
Failure has been fixed by #1882. Thanks! |
|
@henrywang Sorry, I'm not sure I understand—what does that PR have to do with this one? |
There's a failure on |
HastD
force-pushed
the
new-component-packing
branch
from
e1e6807 to
9b3aea9
Compare
|
Could you please sign off commit which is required by |
Under some circumstances--for example, if a new exclusive component has been added since the prior build--packing with a prior build structure can fail. When this happens, we can simply discard the prior build data and make a new packing structure, rather than having chunking fail entirely. Signed-off-by: Daniel Hast <hast.daniel@protonmail.com>
HastD
force-pushed
the
new-component-packing
branch
from
9b3aea9 to
2df4be5
Compare
2 participants
Under some circumstances—for example, if a new exclusive component has been added since the prior build—packing with a prior build structure can fail. When this happens, we can simply discard the prior build data and make a new packing structure, rather than having chunking fail entirely.
This should fix coreos/rpm-ostree#5545, and I think it'll also fix the test failure that was observed in CI for coreos/rpm-ostree#5535.