fix bug: bounds are calculated incorrectly when scale is setting#960
Open
sncer wants to merge 1 commit intobokuweb:masterfrom
Open
fix bug: bounds are calculated incorrectly when scale is setting#960sncer wants to merge 1 commit intobokuweb:masterfrom
sncer wants to merge 1 commit intobokuweb:masterfrom
Conversation
bokuweb
reviewed
Feb 23, 2025
| const parentTop = parentRect.top; | ||
| const left = (boundaryLeft - parentLeft) / scale; | ||
| const top = boundaryTop - parentTop; | ||
| const top = boundaryTop - parentTop / scale; |
Author
There was a problem hiding this comment.
yes，it should be const top = (boundaryTop - parentTop) / scale;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the scale value is not 1, the top and bottom of the bounds are incorrectly divided by the scale