Refactor: Use logging module for diagnostics and warnings instead of print statements #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: harshvardhan.yashvardhan <harshvardhan.yashvardhan@gmail.com>
…-bitsandbytes-0cc5 Logging conversion bitsandbytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all print() statements with logging calls and add a NullHandler to the top-level logger to allow downstream users to manage and filter library logs.
This change prevents bitsandbytes from writing directly to stdout/stderr from library code paths, making its logging opt-in. The CLI entrypoint (python -m bitsandbytes) now configures logging only for its run, respecting the BNB_LOG_LEVEL environment variable.
With respect to #919