[28] Fixes container width and height values causing layout issues when changing theme or updating settings.layout.contentSize value in theme.json#38
Closed
PaulREnglish wants to merge 7 commits intomainfrom
Conversation
Fixes an issue where editing settings.layout.contentSize in theme.json would not change the width of the block.
This was needed to fix 'Arrow function has a complexity of 12. Maximum allowed is 10' JS lint error
Author
|
Converting to draft as there is a few changes I need to implement to make some of the other tickets mentioned in #32 a bit easier. |
This reverts commit 8c657d8.
This was needed to fix 'Arrow function has a complexity of 12. Maximum allowed is 10' JS lint error
6 tasks
updating settings.layout.contentSize value in theme.jsonupdating settings.layout.contentSize value in theme.json
Collaborator
|
Closed as superseded by #39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: #28.
Assigns the Image Comparisons
containerHeightandcontainerWidthvalues a default ofnull. This is to avoid an issue where the block won't scale to the new width if thesettings.layout.contentSizesetting intheme.jsonis changed and the user has not set a width yet.Change Log
containerHeightandcontainerWidthvalues not specifically set the by user would not scale when thesettings.layout.contentSizesetting intheme.jsonwould change.Steps to test
Screenshots/Videos
http://bigbite.im/v/KfN5NC
Checklist: