Merge/refactor rendering2#2
Open
BardezAnAvatar wants to merge 132 commits intobfennema:2.0-kingmaker-2.1from
Open
Merge/refactor rendering2#2BardezAnAvatar wants to merge 132 commits intobfennema:2.0-kingmaker-2.1from
BardezAnAvatar wants to merge 132 commits intobfennema:2.0-kingmaker-2.1from
Conversation
Signed-off-by: Benjamin Fennema <benjamin.fennema@gmail.com>
…ngs are happening
…k into Main (for the time being)
…ce that we can override or whatever to make unit testable
…those being only referenced in that class
…Patcher as it is the only code referencing the method
…e calling the method
…only code invoking the method
…ce none of the references to the method were in the Main class
BardezAnAvatar
force-pushed
the
merge/RefactorRendering2
branch
from
3f5f622 to
13cf6eb
Compare
Author
|
Closing to recreate upon latest |
Author
|
Re-opened with rebase onto latest |
Author
|
This PR pulls a LOT of code out of Main and moves it elsewhere, lightening up the load a bit. I don't believe that any of it had any new unit tests written over it, though. |
bfennema
force-pushed
the
2.0-kingmaker-2.1
branch
4 times, most recently
from
9a866e8 to
2b29d93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My second wave of refactoring from July that has been sitting around