-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixes issue/wiki-and-helpmenu (#2174) #3472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue/wiki-and-helpmenu (#2174) #3472
Conversation
|
Issue (2) can be addressed by updating the Wiki; please grant edit access if you would like me to follow up with that change. |
39b7fa0 to
85d8d78
Compare
| @options[:verbose] = true | ||
| end | ||
|
|
||
| opts.on('-a', '--ascii_art', 'Prints BeEF ascii art') do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed there still --ascii_art in the documentation: https://github.com/beefproject/beef/wiki/Configuration#launching-beef
Could you please update the document? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for confusion, but '--ascii_art' command is still there. It's in line 43.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's now '--ascii-art', with the dash in the middle, not underscore 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just updated
https://github.com/beefproject/beef/wiki/Configuration#launching-beef
core/main/console/commandline.rb
Outdated
| exit 0 | ||
| end | ||
|
|
||
| # opts.on('-i', '--interactive', 'Starts with the Console Shell activated') do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the no longer needed code rather than commenting out? It'll keep the code clean. In case we need it in the future, we should figure it out quickly with AI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this part? Or also exit 0?
# opts.on('-i', '--interactive', 'Starts with the Console Shell activated') do
# @options[:interactive] = true
# endThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not a part of help, thus redundant, please delete, thanks
|
Summary Verification (Manual Testing) ✅
|
Pull Request
Category
Bug, Documentation
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: The CLI options defined in core/main/console/commandline.rb, the output of ./beef --help, and the Wiki documentation were inconsistent.
Q: Give a technical rundown of what you have changed (if applicable)
A:
There were two separate issues:
This PR addresses (1) by parsing BeEF CLI options early in the startup script (beef) before loading the core framework and (2) by updating the Wiki to reflect the current CLI options.
In addition, this PR includes minor CLI style improvements:
Wiki Page
https://github.com/beefproject/beef/wiki/Configuration#launching-beef