-
Notifications
You must be signed in to change notification settings - Fork 85
Option to prevent FHRP group assignment from being overwritten (#445) #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
afoster
wants to merge
32
commits into
bb-Ricardo:development
Choose a base branch
from
sol1:445-review
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter-without-site-issue fix: only set the Cluster scope_type if the site_name is not None
fix: handle object and multi-object custom fields correctly
… group ip address overriding
…assignment' into 445-sync-overwriting-FHRP-Group-assignment
…ve set valid types
…ured to prevent a duplicate ip address from being created, causing errors.
…nment Option to prevent FHRP group assignment from being overwritten (bb-Ricardo#445)
Owner
|
Hi, and thank you very much for this PR. I'm still a bit busy but soon will have some time to look at this. Don't worry, just need some more time. |
0655b11 to
499862a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a per source config option (
skip_fhrp_group_ips) to prevent FHRP group IP addresses in Netbox from being overridden by their members, as described in issue #445.