feat(gazelle): Directive controlling pytest ancestor depdencies#3596
feat(gazelle): Directive controlling pytest ancestor depdencies#3596dougthor42 wants to merge 4 commits intobazel-contrib:mainfrom
Conversation
Summary of ChangesHello @dougthor42, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration option for Gazelle's Python extension, allowing users to explicitly control the inclusion of ancestor Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a new Gazelle directive, python_include_ancestor_conftest, which allows users to control whether ancestor conftest.py targets are automatically added as dependencies to py_test targets. The directive is correctly registered, documented, and integrated into the configuration parsing logic. However, the actual implementation that uses this configuration during rule generation appears to be missing from gazelle/python/generate.go. Without this logic, the directive will not function as intended. Additionally, there are minor typos in the documentation and test data.
| case pythonconfig.PythonIncludeAncestorConftest: | ||
| v, err := strconv.ParseBool(strings.TrimSpace(d.Value)) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| config.SetIncludeAncestorConftest(v) |
There was a problem hiding this comment.
The directive is correctly parsed and stored in the configuration here. However, the logic to respect this setting during rule generation seems to be missing from gazelle/python/generate.go. Specifically, the loop that adds ancestor conftest paths (around line 532 in generate.go) should be conditioned on cfg.IncludeAncestorConftest(). Without this change, the directive will have no effect on the generated deps.
| # Directive: `python_include_ancestor_conftest` | ||
|
|
||
| This test case asserts that the `# gazelle:python_include_ancestor_conftest` | ||
| directive correctly includes or excludes ancestor contest targets in `py_test` |
There was a problem hiding this comment.
Typo: "contest" should be "conftest".
1 participant
Fixes #3595.
Add a new directive
python_include_ancestor_conftest, defaulting totrue, that configures whether or not ancestorconftesttargets are added to apy_testtarget's dependencies.