Skip to content

fix(pypi): Ran bazel run //tools/private/update_deps:update_pip_deps#3593

Open
Danielkonge wants to merge 3 commits intobazel-contrib:mainfrom
Danielkonge:update-pip-deps
Open

fix(pypi): Ran bazel run //tools/private/update_deps:update_pip_deps#3593
Danielkonge wants to merge 3 commits intobazel-contrib:mainfrom
Danielkonge:update-pip-deps

Conversation

@Danielkonge
Copy link

This fixes the incompatibility between packaging==24.0 and setuptools==78.1.1 by just updating the requirements.

This works as intended in my own repositories (where I had problems with requirement updates before), but I am not sure if there are still some issues like what caused the original revert of the packaging update. I checked and I don't see any absolute paths in the compiled lock files (as originally mentioned in #908), but I don't know if there are any other known issues.

Another solution is to just pick compatible versions of packaging and setuptools some other way.

This closes #3532.

Note: I haven't updated the changelog, since I was not sure if this solution is even desirable? Or if you prefer to only change packaging and setuptools versions?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Danielkonge, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical dependency incompatibility by updating a wide array of Python package requirements. The change ensures that the project's Python ecosystem remains stable and functional, particularly resolving issues between packaging and setuptools. This update was generated through an automated dependency management tool, aiming to maintain a healthy and up-to-date set of project dependencies.

Highlights

  • Dependency Updates: Updated numerous Python package dependencies, including build, click, importlib_metadata, more_itertools, packaging, pip, pip_tools, pyproject_hooks, setuptools, tomli, wheel, and zipp to their latest versions.
  • Incompatibility Resolution: Resolved an incompatibility issue between packaging==24.0 and setuptools==78.1.1 by performing a comprehensive update of all listed Python requirements.
  • Automated Update Process: The updates were performed by running the bazel run //tools/private/update_deps:update_pip_deps command, indicating an automated process for managing Python dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to update internal PyPI dependencies. However, a critical security vulnerability has been identified: the updated dependency versions and package formats are highly suspicious and do not align with official PyPI releases, suggesting a potential supply chain attack. Specifically, versions for pip, packaging, setuptools, tomli, and zipp are significantly ahead of their official counterparts. The tomli update is particularly concerning as it introduces a platform-specific wheel for a pure-python package, which is a common indicator of malicious intent, and also points to an invalid URL that will break builds. It is strongly recommended to reject this PR and thoroughly investigate the environment that generated these updates.

@Danielkonge
Copy link
Author

Code Review

This pull request attempts to update internal PyPI dependencies. However, a critical security vulnerability has been identified: the updated dependency versions and package formats are highly suspicious and do not align with official PyPI releases, suggesting a potential supply chain attack. Specifically, versions for pip, packaging, setuptools, tomli, and zipp are significantly ahead of their official counterparts. The tomli update is particularly concerning as it introduces a platform-specific wheel for a pure-python package, which is a common indicator of malicious intent, and also points to an invalid URL that will break builds. It is strongly recommended to reject this PR and thoroughly investigate the environment that generated these updates.

I can see that tomli got the wrong version (a mac version), so I will fix that. I am not really sure about the other notes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packaging==24.0 is incompatible with setuptools==78.1.1

1 participant