support mixed in-order recording and replay#132
Merged
Conversation
We require newer headers anyhow, so we may as well remove these ifdefs to clean up the code a bit.
Contributor
|
Hey Ben, have you tried this out with KhronosGroup/OpenCL-CTS#2230 ? The |
Owner
Author
I hadn't - but I just gave this a try and the new tests are passing 👍 I'll leave a few comments on the PR and hopefully it can be merged soon. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: KhronosGroup/OpenCL-Docs#1292
Adds support for recording a command buffer with an in-order queue, and replaying it with an out-of-order queue. In this case, explicit dependencies are added (via command queue barriers), to enforce the in-order behavior.
I will keep this as a draft until the spec changes are merged, at which time the reported extension version will need to be updated.