CMD-Buf supported queue properties#126
Merged
bashbaug merged 1 commit intobashbaug:mainfrom Jan 15, 2025
Merged
Conversation
Owner
|
Thanks, this is great! Do you want to hold off on this one until the headers changes are merged, or try to add in some #ifdefs so it'll work both with newer and older headers? |
Updates to the command-buffer emulation layer to support changes from KhronosGroup/OpenCL-Docs#850 Requires using KhronosGroup/OpenCL-Headers#265 in `external/OpenCL-Headers` and can be used to test CTS changes from KhronosGroup/OpenCL-CTS#2101
EwanC
force-pushed
the
ewan/cmd_buf_supported_props
branch
from
35bc432 to
e66f9d9
Compare
Contributor
Author
Let's just wait for the headers to be merged, which hopefully won't be long now |
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CTS
that referenced
this pull request
Jan 14, 2025
CTS test update to match OpenCL-Doc & OpenCL-Header PRs: * KhronosGroup/OpenCL-Headers#265 * KhronosGroup/OpenCL-Docs#850 Tested with bashbaug/SimpleOpenCLSamples#126 locally using a checkout of the linked OpenCL-Headers branch
Contributor
Author
|
Headers are merged now, so this PR could be merged as-is (if approved) |
bashbaug
approved these changes
Jan 15, 2025
Owner
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
I'm going to merge this as-is, since I think it's needed to build with the latest headers now :).
We can always make follow-on changes in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the command-buffer emulation layer to support changes from KhronosGroup/OpenCL-Docs#850
Requires using KhronosGroup/OpenCL-Headers#265 in
external/OpenCL-Headersand can be used to test CTS changes from KhronosGroup/OpenCL-CTS#2101