Fix rate limiting in tests #2263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Rails uses the cache_store for rate limiting. Since the test environment uses :null_store, rate limiting was silently disabled in tests. This configures a separate :memory_store for action_controller.cache_store so rate limiting actually works in tests. The cache is cleared in the IntegrationTest setup to prevent rate limit data from persisting across tests. Also updates the join_codes_controller_test to stub the correct cache store. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
not much limiting works to do
|
|
It's not recommended to change it globally, I think that commit maybe misleading and I will fix it. Because tests that hit the cache using an in-memory store will be slower than using a nullstore for no reason whatsoever, if they are not depending on the persisted cache behavior. The point was meant to be if your testing that behavior should you enable it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
config.action_controller.cache_store = :memory_storeso rate limiting works in testsIntegrationTestsetup to prevent state leaking across testsjoin_codes_controller_testto stub the correct cache storeContext
Rails uses
config.cache_storefor rate limiting by default. Since test environment uses:null_store, ratelimiting was silently disabled. See rails/rails#56183.