refactor(cli-utils): RuntimeManager API Updates #418
Merged
+23
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate runtime utilities by replacing separate build_runtime(), run_until_ctrl_c(), and run_until_ctrl_c_fallible() methods with a simpler tokio_runtime() and unified run_until_ctrl_c() that handles runtime creation internally. Ported from #395.
Collaborator
✅ Heimdall Review Status
|
haardikk21
reviewed
Jan 13, 2026
Collaborator
haardikk21
left a comment
haardikk21
left a comment
There was a problem hiding this comment.
one question, lgtm otherwise
Comment on lines
24
to
27
| res = fut => res, | ||
| _ = tokio::signal::ctrl_c() => { | ||
| tracing::info!(target: "cli", "Received Ctrl-C, shutting down..."); | ||
| Ok(()) |
Collaborator
There was a problem hiding this comment.
I believe these get matched on in order right? the prev version was biased towards the ctrl c handler over the future resolving - do we want to maintain that behaviour?
Contributor
Author
There was a problem hiding this comment.
Ah good callout, can bias it towards ctrl+c. By default tokio select! fairness is random so it'd make more sense to bias here.
| fn main() -> eyre::Result<()> { | ||
| Version::init(); | ||
| let cli = MyCli::parse(); | ||
| let _cli = MyCli::parse(); |
Collaborator
There was a problem hiding this comment.
why is the commented code sample underscored 😅 is the linter running on these code blocks too somehow?
Contributor
Author
There was a problem hiding this comment.
Yea the linter runs on rust code docs. Can ignore by writing ```rust,ignore
danyalprout
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ported from #395.
Consolidate runtime utilities by replacing separate
build_runtime(),run_until_ctrl_c(), andrun_until_ctrl_c_fallible()methods with a simplertokio_runtime()and unifiedrun_until_ctrl_c()that handles runtime creation internally.