fix(parser): detect filetype from file content (shebang/modeline) #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file has no extension but contains a shebang (e.g., `#!/bin/bash`),
filetype detection now reads the first 10 lines from disk and uses
`vim.filetype.match({ filename, contents })` for content-based detection.
This enables syntax highlighting for files like `build` scripts that rely
on shebang detection, even when the file isn't open in a buffer.
Detection order:
1. Existing buffer's filetype (already implemented in #69)
2. File content (shebang/modeline) - NEW
3. Filename extension only
Also adds `filetype on` to test helpers to ensure `vim.g.ft_ignore_pat`
is set, which is required for shell detection.
barrettruth
force-pushed
the
fix/filetype-from-file-content
branch
from
0dc8a0e to
33c58c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file has no recognizable extension, filetype detection now falls back to reading file content.
The problem: Files like
build(no extension) got no syntax highlighting when expanded in fugitive status, becausevim.filetype.match({ filename = "build" })returns nil without content hints.The fix: When filename-based detection fails, read the first 10 lines from disk and use
vim.filetype.match({ filename, contents })for content-based detection.Detection order:
This catches shebangs (
#!/bin/bash), XML declarations, and other patterns Neovim detects from early file content.Also:
filetype onto test helpers (required forvim.g.ft_ignore_patwhich shell detection depends on)