Python3 compatibility issue with scripts/x12xml.py creating blocking error#69
Open
ddw360 wants to merge 1 commit intoazoner:masterfrom
Open
Python3 compatibility issue with scripts/x12xml.py creating blocking error#69ddw360 wants to merge 1 commit intoazoner:masterfrom
ddw360 wants to merge 1 commit intoazoner:masterfrom
Conversation
… 0 and None are no longer equivalent.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue reported in #48
In Python3 boolean comparison operator usage with 0 when value is None are no longer equivalent.
Modification is made to the scripts/x12xml.py file to first check if args.verbose is not None and has a valid integer type before further evaluation with a boolean comparison operator.