Skip to content

Conversation

@phlax
Copy link
Contributor

@phlax phlax commented Dec 12, 2025

In our (envoy) build we use a sysroot to ensure hermetic builds.

This fixes a problem where configure is passed the sysroot flag and detects kernel headers for openat2.h but then make doesnt have the sysroot and fails.


git request-pull output:

The following changes since commit 4235cf5db414884887e4b5599311c59c31d71085:

  test: remove t_sqe_prep_cmd() (2025-10-24 12:27:09 -0600)

are available in the Git repository at:

  origin/make-cflags 

for you to fetch changes up to 28123d5ef766c5d0dc5604187dfe57d624205dcf:

  build: Pass env CFLAGS through to make (2025-12-12 12:54:13 +0000)

----------------------------------------------------------------
Ryan Northey (1):
      build: Pass env CFLAGS through to make

 configure    | 10 ++++++++--
 src/Makefile |  2 +-
 2 files changed, 9 insertions(+), 3 deletions(-)


Click to show/hide pull request guidelines

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

123456789+username@users.noreply.github.com

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <axboe@kernel.dk>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

In our (envoy) build we use a sysroot to ensure hermetic builds.

This fixes a problem where configure is passed the sysroot flag and
detects kernel headers for openat2.h but then make doesnt have the sysroot
and fails.

Signed-off-by: Ryan Northey <ryan@synca.io>
@axboe axboe merged commit e07a859 into axboe:master Dec 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants