Fix unhandled exception in error logging by providing the same number of vars and args#130
Open
PaulJSchellenberg wants to merge 1 commit intoawslabs:masterfrom
Open
Fix unhandled exception in error logging by providing the same number of vars and args#130PaulJSchellenberg wants to merge 1 commit intoawslabs:masterfrom
PaulJSchellenberg wants to merge 1 commit intoawslabs:masterfrom
Conversation
gordonpn
approved these changes
Dec 15, 2025
Author
|
Happy new year Gordon, I was wondering if you could reach out to some peers for a second review on this pr. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This particular log line, if it can't detect the environment will throw an unhandled exception
TypeError: not all arguments converted during string formattingThis is because I think it's just not using the logging library correctly. Example usage: https://docs.python.org/3/howto/logging-cookbook.html#customized-exception-formatting
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.