Updated README to use the right case for the set_property function#125
Open
AntwaneB wants to merge 2 commits intoawslabs:masterfrom
Open
Updated README to use the right case for the set_property function#125AntwaneB wants to merge 2 commits intoawslabs:masterfrom
set_property function#125AntwaneB wants to merge 2 commits intoawslabs:masterfrom
Conversation
The examples setting dimensions mentioned to use `setProperty` when dealing with high cardinality metrics. This should instead refer to `set_property`, which is the Python method and the one referred to throughout the rest of the README. The current casing might lead to confusion and make users believe there is a separate `setProperty` function.
gordonpn
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
The examples setting dimensions mentioned to use
setPropertywhen dealing with high cardinality metrics. This should instead refer toset_property, which is the Python method and the one referred to throughout the rest of the README. The current casing might lead to confusion and make users believe there is a separatesetPropertyfunction.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.