-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Java V2 Add Inspector examples #7660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
debora-ito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one comment, looks good otherwise.
javav2/example_code/inspector/src/main/java/com/java/inspector/InspectorScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/inspector/src/main/java/com/java/inspector/InspectorScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/inspector/src/main/java/com/java/inspector/InspectorActions.java
Outdated
Show resolved
Hide resolved
javav2/example_code/inspector/src/main/java/com/java/inspector/InspectorScenario.java
Outdated
Show resolved
Hide resolved
javav2/example_code/inspector/src/test/java/InspectorTests.java
Outdated
Show resolved
Hide resolved
javav2/example_code/inspector/src/main/java/com/java/inspector/InspectorActions.java
Outdated
Show resolved
Hide resolved
b905173 to
5ae383a
Compare
| // snippet-start:[inspector.java2.list_coverage.main] | ||
|
|
||
| /** | ||
| * Lists AWS Inspector2 coverage details for scanned resources using a paginator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments say this method uses a paginator, but I don't see a paginator used.
| } | ||
| } | ||
| } | ||
| // snippet-end:[inspector.java2.hello.main] No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot for a "hello service" example. Any way we can trim it to just one operation instead of 3?
This pull request adds Javas V2 Inspector examples
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.