Remove CreateAdditionalModelRequestFields from BedrockChatClient #4226
+11
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown parameters cause models to hard fail, and most of these settings are not supported by most of the models exposed in bedrock. A developer can use RawRepresentationFactory to populate these themselves if they really want them, so for now at least, this just gets rid of the possibly problematic settings.
dscpinheiro
approved these changes
Dec 11, 2025
Contributor
dscpinheiro
left a comment
dscpinheiro
left a comment
There was a problem hiding this comment.
Dry-run (DRY_RUN-8e4d4596-d69f-4594-9cfd-1d0b6ac99cb5) succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove CreateAdditionalModelRequestFields from BedrockChatClient
Motivation and Context
Unknown parameters cause models to hard fail, and most of these settings are not supported by most of the models exposed in bedrock. A developer can use RawRepresentationFactory to populate these themselves if they really want them, so for now at least, this just gets rid of the possibly problematic settings.
Testing
Unit tests
Screenshots (if appropriate)
Types of changes
Checklist
License