fix: improve sed portability across GNU and BSD implementations#192
Open
fix: improve sed portability across GNU and BSD implementations#192
Conversation
Use temp file approach instead of in-place editing to avoid compatibility issues between GNU sed (-i without space) and BSD sed (-i with space for backup extension). This ensures harbor.sh works correctly regardless of which sed implementation is installed (common issue on macOS with Homebrew's GNU sed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The original code used
unameto detect macOS and assumed BSD sed, but:-i(in-place) syntaxSolution
sed pattern file > temp && mv temp fileTest plan
/usr/bin/sed)harbor.sh lnworks without errors